Skip to content

Make Application Passwords toggle visible only for WP.com authenticated users #16086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 5, 2025
Merged

Make Application Passwords toggle visible only for WP.com authenticated users #16086

merged 4 commits into from
Sep 5, 2025

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Sep 4, 2025 •
edited
Loading

WOOMOB-1189

Description

Follows the suggestion and adds !stores.isAuthenticatedWithoutWPCom as a part of experiment feature availability condition. The toggle should be shown only when the user is signed in using WordPress.com account.

Testing steps

  • Use alpha build or run from Xcode
  • Authenticate to a store with WP.com account.
  • Navigate to "Experimental Features" menu.
  • Make sure the "Application Password" feature is visible.
  • Logout
  • Login to a store with store credentials
  • Navigate to "Experimental Features" menu.
  • Make sure the "Application Password" feature is hidden.

Testing info

Tested on iOS 18.4 simulator and team shared testing store.

Screenshots

N/A

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.2 milestone Sep 4, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Sep 4, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 4, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16086-bd7276a
Version23.1
Bundle IDcom.automattic.alpha.woocommerce
Commitbd7276a
Installation URL7pjfp3aprb2f8
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo self-requested a review September 5, 2025 02:50
@wpmobilebot wpmobilebot modified the milestones: 23.2, 23.3 Sep 5, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 5, 2025

Version 23.2 has now entered code-freeze, so the milestone of this PR has been updated to 23.3.

@itsmeichigo itsmeichigo self-assigned this Sep 5, 2025
itsmeichigo
itsmeichigo approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, code changes look good too 👍

RafaelKayumov
RafaelKayumov commented Sep 5, 2025
View reviewed changes
...asses/ViewRelated/Dashboard/Settings/Beta features/ApplicationPasswordsExperimentState.swift
Comment on lines +69 to +72
//For now rely on local FF for mocked value to avoid unwanted exposure
let mockResultValue = ServiceLocator.featureFlagService.isFeatureFlagEnabled(
.applicationPasswordExperiment
)
Copy link
Contributor Author

@RafaelKayumov RafaelKayumov Sep 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsmeichigo I'm gonna re-create this PR and target the beta. Otherwise the feature toggle will be visible to users. There is no remote FF yet integrated.

Copy link
Contributor

@itsmeichigo itsmeichigo Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - I missed that. You can merge this PR and create a PR targeting beta with only the replacement of the mock result for simplicity. When merging back to trunk, the change will not cause any conflict because it's identical with trunk.

@RafaelKayumov RafaelKayumov merged commit e702542 into trunk Sep 5, 2025
20 of 22 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1189-additinal-feature-availability-checks branch September 5, 2025 09:20
@RafaelKayumov RafaelKayumov mentioned this pull request Sep 5, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

Assignees

@itsmeichigo itsmeichigo

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.3

Development

Successfully merging this pull request may close these issues.

4 participants

@RafaelKayumov @wpmobilebot @itsmeichigo